-
Notifications
You must be signed in to change notification settings - Fork 20
chore(ci): Align GitHub workflows across Python projects #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
240be18
chore(ci): Run code checks directly in pre-release workflow
vdusek d073f4d
add workflow call
vdusek 1ba2b9c
fix needs
vdusek 23ce5cc
fix needs
vdusek c263658
Separate code_checks and doc_checks
vdusek 88637c2
Naming update
vdusek d7edc5e
rm todo to conda
vdusek 463e5c9
revert docs build and publish NPM-related changes
vdusek 2966996
Update
vdusek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Code checks | ||
|
|
||
| on: | ||
| # Runs when manually triggered from the GitHub UI. | ||
| workflow_dispatch: | ||
|
|
||
| # Runs when invoked by another workflow. | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| actions_lint_check: | ||
| name: Actions lint check | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| - name: Run actionlint | ||
| uses: rhysd/actionlint@v1.7.9 | ||
|
|
||
| lint_check: | ||
| name: Lint check | ||
| uses: apify/workflows/.github/workflows/python_lint_check.yaml@main | ||
| with: | ||
| python-versions: '["3.10", "3.11", "3.12", "3.13", "3.14"]' | ||
|
|
||
| type_check: | ||
| name: Type check | ||
| uses: apify/workflows/.github/workflows/python_type_check.yaml@main | ||
| with: | ||
| python-versions: '["3.10", "3.11", "3.12", "3.13", "3.14"]' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: Doc checks | ||
|
|
||
| on: | ||
| # Runs when manually triggered from the GitHub UI. | ||
| workflow_dispatch: | ||
|
|
||
| # Runs when invoked by another workflow. | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| doc_checks: | ||
| name: Doc checks | ||
| uses: apify/workflows/.github/workflows/python_docs_check.yaml@main | ||
| secrets: inherit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Tests | ||
|
|
||
| on: | ||
| # Runs when manually triggered from the GitHub UI. | ||
| workflow_dispatch: | ||
|
|
||
| # Runs when invoked by another workflow. | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| unit_tests: | ||
| name: Unit tests | ||
| uses: apify/workflows/.github/workflows/python_unit_tests.yaml@main | ||
| secrets: inherit | ||
| with: | ||
| python-versions: '["3.10", "3.11", "3.12", "3.13", "3.14"]' | ||
| operating-systems: '["ubuntu-latest", "windows-latest"]' | ||
| python-version-for-codecov: "3.14" | ||
| operating-system-for-codecov: ubuntu-latest | ||
|
|
||
| integration_tests: | ||
| name: Integration tests | ||
| uses: apify/workflows/.github/workflows/python_integration_tests.yaml@main | ||
| secrets: inherit | ||
| with: | ||
| python-versions: '["3.10", "3.14"]' | ||
| operating-systems: '["ubuntu-latest"]' | ||
| python-version-for-codecov: "3.14" | ||
| operating-system-for-codecov: ubuntu-latest |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 3 additions & 2 deletions
5
.github/workflows/update_new_issue.yaml → .github/workflows/on_issue.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: CI (master) | ||
|
|
||
| on: | ||
| # Runs on every push to the master branch. | ||
| push: | ||
| branches: | ||
| - master | ||
| tags-ignore: | ||
| - "**" # Ignore all tags to avoid duplicate executions triggered by tag pushes. | ||
|
|
||
| jobs: | ||
| doc_checks: | ||
| name: Doc checks | ||
| uses: ./.github/workflows/_check_docs.yaml | ||
| secrets: inherit | ||
|
|
||
| code_checks: | ||
| name: Code checks | ||
| uses: ./.github/workflows/_check_code.yaml | ||
|
|
||
| tests: | ||
| name: Tests | ||
| uses: ./.github/workflows/_tests.yaml | ||
| secrets: inherit | ||
|
|
||
| pre_release: | ||
| name: Pre-release | ||
| needs: [code_checks, tests] | ||
| uses: ./.github/workflows/_release_pre.yaml | ||
| secrets: inherit | ||
|
|
||
| release_docs: | ||
| name: Doc release | ||
| needs: [doc_checks, pre_release] | ||
| uses: ./.github/workflows/_release_docs.yaml | ||
| with: | ||
| ref: ${{ needs.pre_release.outputs.changelog_commitish }} | ||
| secrets: inherit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: CI (PR) | ||
|
|
||
| on: | ||
| # Runs whenever a pull request is opened or updated. | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| check_pr_title: | ||
| name: Check PR title | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: amannn/action-semantic-pull-request@v6.1.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| doc_checks: | ||
| name: Doc checks | ||
| uses: ./.github/workflows/_check_docs.yaml | ||
| secrets: inherit | ||
|
|
||
| code_checks: | ||
| name: Code checks | ||
| uses: ./.github/workflows/_check_code.yaml | ||
|
|
||
| tests: | ||
| name: Tests | ||
| uses: ./.github/workflows/_tests.yaml | ||
| secrets: inherit |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.