Skip to content

fix: Prevent mutation of default URL patterns list in block_requests #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Jan 30, 2026
+1 −2
Merged

fix: Prevent mutation of default URL patterns list in block_requests #1702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/crawlee/crawlers/_playwright/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ async def block_requests(
url_patterns: List of URL patterns to block. If None, uses default patterns.
extra_url_patterns: Additional URL patterns to append to the main patterns list.
"""
url_patterns = url_patterns or _DEFAULT_BLOCK_REQUEST_URL_PATTERNS

url_patterns = list(url_patterns or _DEFAULT_BLOCK_REQUEST_URL_PATTERNS)
url_patterns.extend(extra_url_patterns or [])

browser_type = page.context.browser.browser_type.name if page.context.browser else 'undefined'
Expand Down
Loading