feat: add requestFinished event for per request tracking#604
Draft
feat: add requestFinished event for per request tracking#604
Conversation
Contributor
Author
|
I am waiting for #602 to be merged so I can use the HTTPS implementation here and mitigate conflicts from large updates. |
52a673f to
2d4a83f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
requestFinishedevent to enable per-request tracking, complementing the existing socket-level tracking provided by theconnectionClosedevent. Implements #589Key Changes:
requestFinishedEvent: The server now emits arequestFinishedevent upon the completion of a proxied request. This event provides granular details about each request, including its id, connectionId, and the original request object.requestFinishedevent is emitted reliably across various proxy configurations, including HTTP, HTTPS, and scenarios with upstream proxies.examples/request_finished.js, to demonstrate how to listen for and utilize therequestFinishedevent for monitoring purposes.This enhancement provides more detailed visibility into individual requests flowing through the proxy, allowing for better logging and tracking.
Reference to previous PR: #590