Refactor Client.call() to use middlewares#145
Open
stnguyen90 wants to merge 3 commits intofeat-offline-support-refactorfrom
Open
Refactor Client.call() to use middlewares#145stnguyen90 wants to merge 3 commits intofeat-offline-support-refactorfrom
stnguyen90 wants to merge 3 commits intofeat-offline-support-refactorfrom
Conversation
Previously, we added various caching metadata in the services and passed those to the Client so that the Client knew where to cache the data. This was a little messy and decentralized the offline support code. By adding a router, we can match against the path the Client receives and determine where to cache the data.
stnguyen90
commented
May 5, 2023
| @@ -0,0 +1,80 @@ | |||
| final routes = [ | |||
Contributor
Author
There was a problem hiding this comment.
I was thinking this could be generated by the SDK generator.
Member
There was a problem hiding this comment.
Well, i'm okay with generating by SDK generator if that is easier than hardcoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Break apart
Client.call()using middlewares.Test Plan
Manual
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes