Use cursor-based pagination in iterateAllThreads

[TorstenDittmann]

What does this PR do?

Moving to cursor pagination when fetching all threads.

Have you read the Contributing Guidelines on issues?

✅

Summary by CodeRabbit

• Refactor
  • Improved thread data pagination handling for enhanced performance and efficiency when retrieving large thread collections.

[coderabbitai]

Walkthrough

The iterateAllThreads function in src/routes/threads/helpers.ts transitions from offset-based pagination to cursor-based pagination. The function now maintains a cursor (tracking the last item ID) and a count variable instead of manually incrementing an offset. Query construction is dynamic, incorporating a limit and optional cursorAfter parameter. The iteration yields each thread, increments the count, and terminates early when the specified total is reached, replacing the previous offset progression and total-based break logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: implementing cursor-based pagination in the iterateAllThreads function, which aligns with the file modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-threads-use-cursor-pagination

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/routes/threads/helpers.ts (1)

124-149: ⚠️ Potential issue | 🟡 Minor

Handle total = 0 before fetching.

With total = 0, the generator still fetches and yields at least one thread before returning. If callers can pass 0, consider an early return.

✅ Suggested fix

 export async function* iterateAllThreads(total: number | undefined = undefined) {
     const limit = 100;
     let cursor: string | undefined = undefined;
     let count = 0;
+    if (total !== undefined && total <= 0) {
+        return;
+    }
     while (true) {

🤖 Fix all issues with AI agents

In `@src/routes/threads/helpers.ts`:
- Around line 124-138: iterateAllThreads currently paginates without a
deterministic order, causing unstable cursor pagination; update the query set in
iterateAllThreads to include an explicit ordering (e.g.,
Query.orderAsc('$sequence') for monotonic insertion order) before calling
databases.listDocuments, ensuring the same ordering is applied when you pass a
cursor so pages are stable and no duplicates/skip occur; also apply the same
explicit order change to the other pagination site in this file (compare with
getThreads which uses Query.orderDesc('$createdAt')) so both methods use a
consistent, deterministic order.