-
Notifications
You must be signed in to change notification settings - Fork 669
Add dialog to install EFI bootloader to removable location #3932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f5af338 to
cba59d8
Compare
|
i think this should go under a new Bootloader sub-menu instead of a global namespace setting. |
8632ca0 to
101b56c
Compare
|
The PR should be ready for review now. Please, beware that I have used LLMs for most of these changes due to my unfamiliarity with the codebase, and while I have reviewed and tested the code, I would strongly recommend someone familiar with the codebase to thoroughly review the changes. |
9f13022 to
2ac2d75
Compare
This is just for GRUB and Limine for now.
|
@svartkanin alright, sorry, I added a bunch more commits, but I should be done now, at least for what this PR is concerned. |
|
Anything else I should change before approval? |
|
Sorry I was too busy, I tested the code and it seems to work, great job in making the config backwards compatible. |
0c5c3ee to
3c349a0
Compare
3c349a0 to
2acdaef
Compare
This is just for GRUB and Limine for now.