Skip to content

Conversation

@mintsuki
Copy link
Contributor

This is just for GRUB and Limine for now.

@mintsuki mintsuki requested a review from Torxed as a code owner November 16, 2025 05:03
@mintsuki mintsuki marked this pull request as draft November 16, 2025 05:05
@mintsuki mintsuki force-pushed the limine-removable branch 6 times, most recently from f5af338 to cba59d8 Compare November 16, 2025 06:23
@mintsuki mintsuki marked this pull request as ready for review November 16, 2025 06:40
@svartkanin
Copy link
Collaborator

i think this should go under a new Bootloader sub-menu instead of a global namespace setting.
The current bootloader selection should go in there together with this setting

@mintsuki mintsuki marked this pull request as draft November 16, 2025 18:26
@mintsuki mintsuki force-pushed the limine-removable branch 4 times, most recently from 8632ca0 to 101b56c Compare November 16, 2025 19:50
@mintsuki mintsuki marked this pull request as ready for review November 16, 2025 20:52
@mintsuki
Copy link
Contributor Author

The PR should be ready for review now.

Please, beware that I have used LLMs for most of these changes due to my unfamiliarity with the codebase, and while I have reviewed and tested the code, I would strongly recommend someone familiar with the codebase to thoroughly review the changes.

@mintsuki mintsuki requested a review from svartkanin November 16, 2025 20:54
@mintsuki mintsuki force-pushed the limine-removable branch 3 times, most recently from 9f13022 to 2ac2d75 Compare November 16, 2025 22:16
@mintsuki
Copy link
Contributor Author

@svartkanin alright, sorry, I added a bunch more commits, but I should be done now, at least for what this PR is concerned.

@mintsuki
Copy link
Contributor Author

Anything else I should change before approval?

@svartkanin
Copy link
Collaborator

Sorry I was too busy, I tested the code and it seems to work, great job in making the config backwards compatible.
I left some small comments if you can address those then we can merge the PR

@mintsuki mintsuki force-pushed the limine-removable branch 13 times, most recently from 0c5c3ee to 3c349a0 Compare November 20, 2025 13:40
@svartkanin svartkanin merged commit eb815d8 into archlinux:master Nov 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants