Skip to content

Fix GRUB fallback-from-removable logic introduced in c095eb56d8 #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 1 commit into from
Nov 29, 2025
Merged

Fix GRUB fallback-from-removable logic introduced in c095eb56d8 #3950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions archinstall/lib/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,11 +1321,15 @@ def _add_grub_bootloader(

try:
SysCommand(command, peek_output=True)
except SysCallError:
try:
SysCommand(command, peek_output=True)
except SysCallError as err:
raise DiskError(f'Could not install GRUB to {self.target}{efi_partition.mountpoint}: {err}')
except SysCallError as err:
if not bootloader_removable:
command.append('--removable')
try:
SysCommand(command, peek_output=True)
except SysCallError:
pass

raise DiskError(f'Could not install GRUB to {self.target}{efi_partition.mountpoint}: {err}') from err
Copy link
Contributor

@correctmost correctmost Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the fallback branch with --removable will always fall through and raise an exception here. Am I overlooking something?

else:
info(f'GRUB boot partition: {boot_partition.dev_path}')

Expand Down