-
Notifications
You must be signed in to change notification settings - Fork 669
Hwclock/Tz - disclaimer and display #4002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5fb1d28
6537319
d1d56ca
b772d34
34455d3
edb6a2d
f82e252
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,9 +150,10 @@ def _get_menu_options(self) -> list[MenuItem]: | |
| MenuItem( | ||
| text=tr('Timezone'), | ||
| action=ask_for_a_timezone, | ||
| value='UTC', | ||
| value=None, | ||
| preview_action=self._prev_tz, | ||
| key='timezone', | ||
| mandatory=True, | ||
| ), | ||
| MenuItem( | ||
| text=tr('Automatic time sync (NTP)'), | ||
|
|
@@ -330,7 +331,12 @@ def _prev_applications(self, item: MenuItem) -> str | None: | |
|
|
||
| def _prev_tz(self, item: MenuItem) -> str | None: | ||
| if item.value: | ||
| return f'{tr("Timezone")}: {item.value}' | ||
| output = f'{tr("Timezone")}: {item.value}' | ||
| return output | ||
| else: | ||
| # Show RTC time when no timezone is selected yet | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When would that happen? Isn't
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Basically I thought it would avoid a lot of errors just to set to I also thought that RTC time is relevant here for people doing offline installs using archiso fully cached |
||
| if rtc_time := SysInfo.hw_clock(): | ||
| return f'RTC time: {rtc_time}' | ||
| return None | ||
|
|
||
| def _prev_ntp(self, item: MenuItem) -> str | None: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not leaving it here as default with all the others?