-
Notifications
You must be signed in to change notification settings - Fork 672
feat(applications): add support for power-profiles-daemon/tuned as a power management daemon #4015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sigreturn
wants to merge
13
commits into
archlinux:master
Choose a base branch
from
sigreturn:fix/install-ppd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+140
−1
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c5a24db
fix(profiles): install power-profiles-daemon by default in the desktop
sigreturn a5573ce
fix: only install power-profiles-daemon if a battery is detected
sigreturn 9b12c6a
chore: clean up has_battery method
sigreturn 9b6765d
fix: make power management daemon a configurable application
sigreturn 7bbde5c
Merge branch 'master' into fix/install-ppd
sigreturn 42e91a7
fix: make linter happy after merge
sigreturn 41e0b91
fix: fix merge issues
sigreturn 2ae217b
fix: give has_battery a return type to make linter happy
sigreturn 09cb91a
chore: add locale msgids for power management related strings
sigreturn da35b06
fix: changes requested in review
sigreturn 6706411
fix: cache has_battery result
sigreturn 87383bd
fix: changes requested in review
sigreturn 9cea7af
fix: just return none directly
sigreturn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| from typing import TYPE_CHECKING | ||
|
|
||
| from archinstall.lib.models.application import PowerManagement, PowerManagementConfiguration | ||
| from archinstall.lib.output import debug | ||
|
|
||
| if TYPE_CHECKING: | ||
| from archinstall.lib.installer import Installer | ||
|
|
||
|
|
||
| class PowerManagementApp: | ||
| @property | ||
| def ppd_packages(self) -> list[str]: | ||
| return [ | ||
| 'power-profiles-daemon', | ||
| ] | ||
|
|
||
| @property | ||
| def tuned_packages(self) -> list[str]: | ||
| return [ | ||
| 'tuned', | ||
| 'tuned-ppd', | ||
| ] | ||
|
|
||
| def install( | ||
| self, | ||
| install_session: 'Installer', | ||
| power_management_config: PowerManagementConfiguration, | ||
| ) -> None: | ||
| debug(f'Installing power management daemon: {power_management_config.power_management.value}') | ||
|
|
||
| match power_management_config.power_management: | ||
| case PowerManagement.POWER_PROFILES_DAEMON: | ||
| install_session.add_additional_packages(self.ppd_packages) | ||
| case PowerManagement.TUNED: | ||
| install_session.add_additional_packages(self.tuned_packages) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.