Skip to content

Modify archinstall language display to be handled like other sections. #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svartkanin merged 2 commits into from
Dec 30, 2025
Merged

Modify archinstall language display to be handled like other sections. #4048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66da3e3
Modify archinstall language display to be handled like other sections.
h8d13 Dec 29, 2025
ecddd10
Revert types change
h8d13 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion archinstall/lib/global_menu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def _get_menu_options(self) -> list[MenuItem]:
MenuItem(
text=tr('Archinstall language'),
action=self._select_archinstall_language,
display_action=lambda x: x.display_name if x else '',
preview_action=self._prev_archinstall_language,
key='archinstall_language',
),
MenuItem(
Expand Down Expand Up @@ -239,6 +239,13 @@ def _select_archinstall_language(self, preset: Language) -> Language:

return language

def _prev_archinstall_language(self, item: MenuItem) -> str | None:
if not item.value:
return None

lang: Language = item.value
return f'{tr("Language")}: {lang.display_name}'

def _select_applications(self, preset: ApplicationConfiguration | None) -> ApplicationConfiguration | None:
app_config = ApplicationMenu(preset).run()
return app_config
Expand Down