Skip to content

Allow a bit more time for mocked tests to correctly cleanup. #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 1 commit into from
Dec 9, 2025
Merged

Allow a bit more time for mocked tests to correctly cleanup. #3060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions internal/integrationtest/daemon/discoveries_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package daemon

import (
"fmt"
"os"
"testing"
"time"

Expand Down Expand Up @@ -66,8 +67,15 @@ func TestBoardListMock(t *testing.T) {
}))

// Run a BoardList
resp, err := grpcInst.BoardList(time.Second)
require.NoError(t, err)
var resp *commands.BoardListResponse
for range 5 { // wait up to 5 seconds
resp, err = grpcInst.BoardList(time.Second)
require.NoError(t, err)
if len(resp.Ports) > 0 {
break
}
time.Sleep(time.Second)
}
require.NotEmpty(t, resp.Ports)
for _, port := range resp.Ports {
if port.GetPort().GetProtocol() == "serial" {
Expand All @@ -81,6 +89,14 @@ func TestBoardListMock(t *testing.T) {
}

// Check if the discoveries have been successfully close
for range 5 { // wait up to 5 seconds
_, err1 := os.Lstat(tmp1)
_, err2 := os.Lstat(tmp2)
if err1 != nil && err2 != nil {
break
}
time.Sleep(time.Second)
}
require.NoFileExists(t, tmp1, "discovery has not been closed")
require.NoFileExists(t, tmp2, "discovery has not been closed")
}