Conversation
There was a problem hiding this comment.
@KuktaeKim Please rework this pull request as it undoes the support Mark added for SLAC in ADEuresys::createFeature() for the new feature name string prefixes like DV_, IF_, and SY_.
This pull request should also update the egrabber SDK version in iocs/EuresysIOC/configure/CONFIG_SITE.linux-x86_64.Common.
I would also recommend you move the support for NDBitsPerPixel to a separate pull request as Mark hasn't included our NDBitsPerPixel support in ADCore master branch.
There was a problem hiding this comment.
Hi @bhill-slac,
Thank you for your review. I’ll rework this PR and resubmit it.
There was a problem hiding this comment.
@KuktaeKim Please rework this pull request as it undoes the support Mark added for SLAC in ADEuresys::createFeature() for the new feature name string prefixes like DV_, IF_, and SY_. This pull request should also update the egrabber SDK version in iocs/EuresysIOC/configure/CONFIG_SITE.linux-x86_64.Common. I would also recommend you move the support for NDBitsPerPixel to a separate pull request as Mark hasn't included our NDBitsPerPixel support in ADCore master branch.
I’ve reworked this pull request to only update EgrabberClientVersion to EGrabberApiVersion. Updating configure/CONFIG_SITE.linux-x86_64.Common is unnecessary because the README.md already states that "configure/CONFIG_SITE or CONFIG_SITE.$(EPICS_HOST_ARCH).Common must be edited to point to the local install." The user can create a symbolic link to the current SDK version (e.g., egrabber -> /opt/euresys/egrabber-linux-x86_64-25.02.0.39).
KuktaeKim
changed the title
This change is happend between egrabber-linux-x86_64-24.01.2.67 and egrabber-linux-x86_64-25.02.0.39.
2 participants
In this pull request, I added the following features:
Upgraded the EGrabber SDK version from egrabber-linux-x86_64-24.01.2.67 to egrabber-linux-x86_64-25.02.0.39.
This update required changing EgrabberClientVersion to EGrabberApiVersion.