chore: Update Lean to v4.21.0 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@samuelburnham the Nix-related CI job is failing. How do you think we should proceed? |
Contributor
Author
If I change |
samuelburnham
approved these changes
Aug 8, 2025
Comment on lines
-32
to
-36
| - uses: cachix/cachix-action@v14 | ||
| with: | ||
| name: argumentcomputer | ||
| authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' | ||
| - run: nix build |
Member
There was a problem hiding this comment.
Note that I enabled the Garnix app for this repo so we can try out caching the LSpec package there instead of Cachix
arthurpaulino
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #49 and removes old notations like
List.get!.The most important change is that the old code in
LSpec.SlimCheckrely on constructions such as(n : Nat) -> Fin n.succ, which in turn relies onFin.ofNat. However the semantics ofFin.ofNathas changed, toforall (n : Nat) [NeZero n] (a : Nat), Fin n, so I changed the relevant code inSampleable.leanto this as well.The upstream Nix flake in argumentcomputer/lean4-nix doesn't have a v4.21.0 manifest. lenianiva/lean4-nix has one though.