Skip to content

Remove inline event handlers for CSP compliance #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arjun7965 merged 2 commits into from
Nov 14, 2025
Merged

Remove inline event handlers for CSP compliance #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2927e3e
Initial plan
Copilot Nov 14, 2025
cd3e9b2
Remove inline onclick handlers and move to event listeners
Copilot Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions books.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,15 +217,15 @@
<div class="site-logo"><a href="/">Arjun Vinod</a></div>
<div class="header-right">
<div class="menu-wrapper">
<button class="menu-button" onclick="toggleMenu()" aria-label="Menu" aria-haspopup="true" aria-expanded="false" aria-controls="menu-dropdown">
<button class="menu-button" aria-label="Menu" aria-haspopup="true" aria-expanded="false" aria-controls="menu-dropdown">
<i class="fas fa-bars"></i>
</button>
<nav class="menu-dropdown" id="menu-dropdown" role="navigation" aria-label="Primary Navigation">
<a href="/books.html">Books</a>
</nav>
</div>
<div class="theme-toggle-wrapper">
<button class="theme-toggle" onclick="toggleTheme()" aria-label="Toggle theme" role="switch" aria-checked="false">
<button class="theme-toggle" aria-label="Toggle theme" role="switch" aria-checked="false">
<div class="theme-toggle-slider">
<i class="fas fa-moon"></i>
</div>
Expand Down
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@
<div class="site-logo"><a href="/">Arjun Vinod</a></div>
<div class="header-right">
<div class="menu-wrapper">
<button class="menu-button" onclick="toggleMenu()" aria-label="Menu" aria-haspopup="true" aria-expanded="false" aria-controls="menu-dropdown">
<button class="menu-button" aria-label="Menu" aria-haspopup="true" aria-expanded="false" aria-controls="menu-dropdown">
<i class="fas fa-bars"></i>
</button>
<nav class="menu-dropdown" id="menu-dropdown" role="navigation" aria-label="Primary Navigation">
<a href="/books.html">Books</a>
</nav>
</div>
<div class="theme-toggle-wrapper">
<button class="theme-toggle" onclick="toggleTheme()" aria-label="Toggle theme" role="switch" aria-checked="false">
<button class="theme-toggle" aria-label="Toggle theme" role="switch" aria-checked="false">
<div class="theme-toggle-slider">
<i class="fas fa-moon"></i>
</div>
Expand Down
3 changes: 3 additions & 0 deletions js/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ document.addEventListener('DOMContentLoaded', function() {

if (!menuWrapper || !dropdown || !btn) return;

// Attach event listener to menu button
btn.addEventListener('click', toggleMenu);

// Close dropdown when clicking outside
document.addEventListener('click', function(event) {
if (!menuWrapper.contains(event.target)) {
Expand Down
3 changes: 2 additions & 1 deletion js/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ window.addEventListener('DOMContentLoaded', () => {
console.warn('Theme toggle icon element not found');
}

// Set initial aria-label
// Set initial aria-label and attach event listener
const btn = document.querySelector('.theme-toggle');
if (btn) {
btn.setAttribute('aria-label', theme === 'light' ? 'Switch to dark mode' : 'Switch to light mode');
btn.setAttribute('aria-checked', theme === 'dark' ? 'true' : 'false');
btn.addEventListener('click', toggleTheme);
}
});