Skip to content

adding extra error handling in the length parameter #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Danieljeffery695 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding extra error handling in the length parameter #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,12 @@ function timelydiff(timestamp, length = null) {

//if value > 1, pluralize by adding 's'
let pluralize = trunc > 1 ? "s" : "";
let pattern = /^(short|shorter)$/;

if (length === null) {
return positionTime(`${trunc} ${name.def}${pluralize}`);
} else if (!pattern.test(length)) {
throw new Error("Invalid length parameter. Please use 'short' or 'shorter'.");
}

if (length === "short" || length === "shorter") {
Expand Down
13 changes: 13 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.