Skip to content

Conversation

@kudima03
Copy link
Contributor

@kudima03 kudima03 commented Nov 24, 2025

Fixes #93
Probably the expected number was taken from the last user only.

@ashkulz
Copy link
Owner

ashkulz commented Nov 24, 2025

@kudima03 can you remove the file belarus.yml in the gh-pages branch on your fork and see if it generates properly? You'll probably have to push this change on to your master branch or see if you can run https://github.com/kudima03/committers.top/actions/workflows/daily_update.yml with this branch.

@kudima03
Copy link
Contributor Author

@ashkulz Deleting _data/locations/belarus.yml in gh_pages + running a workflow didn't update Belarus region. Am I doing smth wrong? I can give you collaborator status in my fork if you need.

@ashkulz
Copy link
Owner

ashkulz commented Nov 25, 2025

@kudima03 you'll need to revert ec01972 on your fork -- it made the update process random instead of deterministic 🙈

@kudima03
Copy link
Contributor Author

kudima03 commented Nov 26, 2025

@ashkulz My fix didn’t change the followers count, but it clearly fixes a bug in the mechanism. There was no visible effect because the user list is fetched ordered by followers (desc), and the actual minimum number of users is 11. So the root cause must be somewhere else.

However, the fix itself still seems valid since it corrects the incorrect logic, so it can probably be merged.

If this change will be merged - tell me, I will revert the unnecessary commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimum follower count is incorrect on location-specific pages

2 participants