Skip to content

Conversation

@jbedard
Copy link
Member

@jbedard jbedard commented Dec 23, 2025

Trying to reproduce #362 for testing #2366, the expanded test coverage can be merged now though.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows
Copy link

aspect-workflows bot commented Dec 23, 2025

Bazel 7 (Test)

6 test targets passed

Targets
//examples/npm_deps:test10_cjs [k8-fastbuild]  226ms
//examples/npm_deps:test10_mjs [k8-fastbuild]  265ms
//examples/npm_deps:test7_b_cjs [k8-fastbuild] 351ms
//examples/npm_deps:test7_b_mjs [k8-fastbuild] 331ms
//examples/npm_deps:test9_cjs [k8-fastbuild]   244ms
//examples/npm_deps:test9_mjs [k8-fastbuild]   245ms

Total test execution time was 2s. 301 tests (98.0%) were fully cached saving 1m 32s.


Bazel 8 (Test)

6 test targets passed

Targets
//examples/npm_deps:test10_cjs [k8-fastbuild]  143ms
//examples/npm_deps:test10_mjs [k8-fastbuild]  163ms
//examples/npm_deps:test7_b_cjs [k8-fastbuild] 152ms
//examples/npm_deps:test7_b_mjs [k8-fastbuild] 282ms
//examples/npm_deps:test9_cjs [k8-fastbuild]   187ms
//examples/npm_deps:test9_mjs [k8-fastbuild]   211ms

Total test execution time was 1s. 264 tests (97.8%) were fully cached saving 40s.


Bazel 7 (Test)

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 559ms.


Bazel 7 (Test)

e2e/git_dep_metadata

All tests were cache hits

1 test (100.0%) was fully cached saving 23ms.


Bazel 7 (Test)

e2e/git_dep_no_tar

All tests were cache hits

1 test (100.0%) was fully cached saving 24ms.


Bazel 7 (Test)

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 153ms.


Bazel 7 (Test)

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.


Bazel 7 (Test)

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 206ms.


Bazel 7 (Test)

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 224ms.


Bazel 7 (Test)

e2e/npm_link_package-rerooted

All tests were cache hits

2 tests (100.0%) were fully cached saving 199ms.


Bazel 7 (Test)

e2e/npm_translate_lock

All tests were cache hits

3 tests (100.0%) were fully cached saving 681ms.


Bazel 7 (Test)

e2e/npm_translate_lock_disable_hooks

All tests were cache hits

3 tests (100.0%) were fully cached saving 257ms.


Bazel 7 (Test)

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 180ms.


Bazel 7 (Test)

e2e/npm_translate_lock_exclude_package_contents

All tests were cache hits

1 test (100.0%) was fully cached saving 34ms.


Bazel 7 (Test)

e2e/npm_translate_lock_link_workspace

All tests were cache hits

2 tests (100.0%) were fully cached saving 225ms.


Bazel 7 (Test)

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 164ms.


Bazel 7 (Test)

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 61ms.


Bazel 7 (Test)

e2e/npm_translate_lock_replace_packages

All tests were cache hits

4 tests (100.0%) were fully cached saving 487ms.


Bazel 7 (Test)

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 95ms.


Bazel 7 (Test)

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 324ms.


Bazel 7 (Test)

e2e/patch_from_repo

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/pnpm_lockfiles

All tests were cache hits

82 tests (100.0%) were fully cached saving 9s.


Bazel 7 (Test)

e2e/pnpm_repo_install

All tests were cache hits

1 test (100.0%) was fully cached saving 963ms.


Bazel 7 (Test)

e2e/pnpm_version

All tests were cache hits

1 test (100.0%) was fully cached saving 75ms.


Bazel 7 (Test)

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.


Bazel 7 (Test)

e2e/pnpm_workspace_deps

All tests were cache hits

3 tests (100.0%) were fully cached saving 428ms.


Bazel 7 (Test)

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 3s.


Bazel 7 (Test)

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 394ms.


Bazel 7 (Test)

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 110ms.


Bazel 7 (Test)

e2e/stamped_package_json

All tests were cache hits

1 test (100.0%) was fully cached saving 44ms.


Bazel 7 (Test)

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 70ms.


Bazel 7 (Test)

e2e/vendored_tarfile

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Bazel 7 (Test)

e2e/verify_patches

All tests were cache hits

2 tests (100.0%) were fully cached saving 109ms.


Bazel 7 (Test)

e2e/worker

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.


Bazel 7 (Test)

e2e/workspace

All tests were cache hits

1 test (100.0%) was fully cached saving 35ms.


Buildifier      Format

@jbedard jbedard changed the title test: mocha fs sandbox tests test: update tests to esm Dec 23, 2025
@jbedard jbedard force-pushed the esm-mocha-test branch 2 times, most recently from 29cd43c to a491c96 Compare December 23, 2025 03:12
@jbedard jbedard force-pushed the esm-mocha-test branch 17 times, most recently from 93f08c7 to 20edddd Compare January 5, 2026 20:36
@jbedard jbedard marked this pull request as ready for review January 5, 2026 21:11
@jbedard jbedard requested review from alexeagle and dzbarsky January 5, 2026 21:11
@jbedard jbedard changed the title test: update tests to esm test: add additional esm sandbox assertions Jan 5, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20eddddf83

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jbedard jbedard force-pushed the esm-mocha-test branch 2 times, most recently from fefbbbf to 5843bf8 Compare January 5, 2026 22:08
@jbedard jbedard enabled auto-merge (squash) January 5, 2026 22:22
@jbedard jbedard disabled auto-merge January 5, 2026 22:36
@jbedard jbedard merged commit 049fdf1 into aspect-build:main Jan 5, 2026
113 checks passed
@jbedard jbedard deleted the esm-mocha-test branch January 5, 2026 22:36
jbedard added a commit that referenced this pull request Jan 5, 2026
Trying to reproduce #362 for testing #2366, the expanded test coverage
can be merged now though.

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- New test cases added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants