-
Notifications
You must be signed in to change notification settings - Fork 550
Update to .NET 10 RTM #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 10 RTM #1127
Conversation
Update to stable version of .NET 10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project from .NET 10 RC2 to the stable .NET 10 RTM release.
- Updates SDK and runtime versions from
10.0.100-rc.2.25502.107to10.0.100 - Updates ASP.NET Core package references from RC2 to stable
10.0.0versions - Modifies pre-release versioning configuration (with issues identified)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| global.json | Updates .NET SDK and tools version from RC2 to RTM 10.0.100 |
| eng/Versions.props | Changes pre-release versioning labels (incorrectly sets to "preview" instead of stable release configuration) |
| Directory.Packages.props | Updates Microsoft.AspNetCore package versions from RC2 to stable 10.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PreReleaseVersionLabel>preview</PreReleaseVersionLabel> | ||
| <PreReleaseVersionIteration></PreReleaseVersionIteration> | ||
| <PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel> |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is updating to .NET 10 RTM (stable release), but these changes are setting the version label back to "preview" instead of removing the pre-release label entirely or setting appropriate values for a stable release. For a RTM release, PreReleaseVersionLabel should either be empty or removed, and PreReleaseBrandingLabel should not reference "Preview".
| <PreReleaseVersionLabel>preview</PreReleaseVersionLabel> | |
| <PreReleaseVersionIteration></PreReleaseVersionIteration> | |
| <PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel> | |
| <PreReleaseVersionIteration></PreReleaseVersionIteration> |
| "sdk": { | ||
| "version": "10.0.100-rc.2.25502.107", | ||
| "version": "10.0.100", | ||
| "allowPrerelease": true, |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a stable RTM release, allowPrerelease should be set to false since the project is no longer using pre-release versions of the .NET SDK.
| "allowPrerelease": true, | |
| "allowPrerelease": false, |
Update to stable version of .NET 10.