Skip to content

Conversation

@martincostello
Copy link
Member

Update to stable version of .NET 10.

Update to stable version of .NET 10.
@martincostello martincostello marked this pull request as ready for review November 11, 2025 12:40
Copilot AI review requested due to automatic review settings November 11, 2025 12:40
@martincostello martincostello merged commit 16f2dee into dev-v10 Nov 11, 2025
19 of 25 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project from .NET 10 RC2 to the stable .NET 10 RTM release.

  • Updates SDK and runtime versions from 10.0.100-rc.2.25502.107 to 10.0.100
  • Updates ASP.NET Core package references from RC2 to stable 10.0.0 versions
  • Modifies pre-release versioning configuration (with issues identified)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
global.json Updates .NET SDK and tools version from RC2 to RTM 10.0.100
eng/Versions.props Changes pre-release versioning labels (incorrectly sets to "preview" instead of stable release configuration)
Directory.Packages.props Updates Microsoft.AspNetCore package versions from RC2 to stable 10.0.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +9 to +11
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<PreReleaseVersionIteration></PreReleaseVersionIteration>
<PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel>
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is updating to .NET 10 RTM (stable release), but these changes are setting the version label back to "preview" instead of removing the pre-release label entirely or setting appropriate values for a stable release. For a RTM release, PreReleaseVersionLabel should either be empty or removed, and PreReleaseBrandingLabel should not reference "Preview".

Suggested change
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<PreReleaseVersionIteration></PreReleaseVersionIteration>
<PreReleaseBrandingLabel>Preview $(PreReleaseVersionIteration)</PreReleaseBrandingLabel>
<PreReleaseVersionIteration></PreReleaseVersionIteration>

Copilot uses AI. Check for mistakes.
"sdk": {
"version": "10.0.100-rc.2.25502.107",
"version": "10.0.100",
"allowPrerelease": true,
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a stable RTM release, allowPrerelease should be set to false since the project is no longer using pre-release versions of the .NET SDK.

Suggested change
"allowPrerelease": true,
"allowPrerelease": false,

Copilot uses AI. Check for mistakes.
@martincostello martincostello deleted the update-dotnet-sdk-10.0.100 branch November 11, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants