Skip to content

Conversation

@skogseth
Copy link
Contributor

This function seems to have been incorrectly named elapased_s, which is not a word ofcourse. Just thought I'd fix it. The _s suffix is still a bit confusing to me, but it seems to be used a lot of places in the codebase, so I assume this is intentional.

BREAKING CHANGE: Changes the name of a public method on the type
`TestContext` from `elapased_s` to `elapsed_s`
@epage
Copy link
Collaborator

epage commented Oct 16, 2025

Thanks!

@epage epage enabled auto-merge October 16, 2025 14:11
@epage
Copy link
Collaborator

epage commented Oct 16, 2025

The _s suffix is still a bit confusing to me, but it seems to be used a lot of places in the codebase, so I assume this is intentional.

That is the unit of elapsed time (seconds)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18563963868

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.121%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/libtest2-harness/src/context.rs 0 1 0.0%
crates/libtest2-harness/src/harness.rs 0 3 0.0%
Totals Coverage Status
Change from base Build 18478785504: 0.0%
Covered Lines: 483
Relevant Lines: 1552

💛 - Coveralls

@epage epage merged commit 9f4dfed into assert-rs:main Oct 16, 2025
15 checks passed
@skogseth
Copy link
Contributor Author

The _s suffix is still a bit confusing to me, but it seems to be used a lot of places in the codebase, so I assume this is intentional.

That is the unit of elapsed time (seconds)

That was my first guess, but then I was confused by it using Duration internally. I see now that it has an impl of Display using seconds. All good then :)

@skogseth skogseth deleted the fix/type-in-function-name branch October 20, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants