Conversation
|
A couple new extension modules |
8e5c165 to
185c89b
Compare
|
Alright, now we need to setup zstd |
|
Linux builds should hopefully be good now, if that validation change did what I expected. Mac builds are failing because patch-jit-cflags-314.patch in #544 doesn't quite apply to b1 - Zanie, I'll let you handle that (and maybe you want to try b2 at the same time). If you rebase this branch on top of main, note that 867ca9c reverts fab9ad2, b01c183, and 856ce7e so personally I would ditch all four commits. |
|
Thanks! I'll look at that patch |
|
Windows failing due to some zstd stuff, e.g.: |
| # Do not enable on x86-64 macOS because the JIT requires macOS 11+ and we are currently | ||
| # using 10.15 as a miniumum version. | ||
| if [ "${TARGET_TRIPLE}" != "x86_64-apple-darwin" ]; then | ||
| # Do not enable when free-threading, because they're not compatible yet. |
There was a problem hiding this comment.
This just "didn't work" in previous releases, now they made it a hard error.
|
|
||
| # ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL, | ||
| # but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted | ||
| # in the comments, so just don't even try. (We should check if we can make this conditional) |
| - _xxtestfuzz/fuzzer.c | ||
|
|
||
| _zstd: | ||
| # Disable on all targets until we add a zstd library |
There was a problem hiding this comment.
This will need to come before stable, I can open an issue.
There was a problem hiding this comment.
Created #646 so we don't forget, feel free to edit/rephrase.
|
|
||
| # ./configure tries to auto-detect whether it can build 128-bit and 256-bit SIMD helpers for HACL, | ||
| # but on x86-64 that requires v2 and v3 respectively, and on arm64 the performance is bad as noted | ||
| # in the comments, so just don't even try. (We should check if we can make this conditional) |
There was a problem hiding this comment.
#645. Let's add a link in this comment if we rework this PR.
There was a problem hiding this comment.
Should we send this patch upstream for inclusion in 3.14?
_zstdbindings module python/cpython#133027_zstdon Windows python/cpython#133366_remotedebugging& rename to_remote_debuggingpython/cpython#133398