[CI] Split build dependencies into own job on Windows#984
[CI] Split build dependencies into own job on Windows#984jjhelmus wants to merge 3 commits intoastral-sh:mainfrom
Conversation
jjhelmus
added
platform:windows
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| persist-credentials: false | ||
|
|
||
| - name: Install Cygwin Environment | ||
| uses: cygwin/cygwin-install-action@f2009323764960f80959895c7bc3bb30210afe4d # v6 |
Check warning
Code scanning / zizmor
detects commit SHAs that don't match their version comment tags Warning
|
This would be more useful if a matrix jobs could depend on a specific matrix job rather than the entire jobs to finish. In this way to x86-64+PGO Python builds could start as soon as the x86-64+PGO build-deps job finished rather than waiting for all matrix elements of |
| outputs: | ||
| matrix: ${{ steps.set-matrix.outputs.matrix }} | ||
| crate-build-matrix: ${{ steps.set-matrix.outputs.crate-build-matrix }} | ||
| dep-build-matrix: ${{ steps.set-matrix.outputs.dep-build-matrix }} |
There was a problem hiding this comment.
nit: We generally prefer verbose names like "dependency" over short ones like "dep"
| timeout-minutes: 90 | ||
| needs: | ||
| - generate-matrix | ||
| # Permissions used for actions/attest-build-provenance |
There was a problem hiding this comment.
What is this comment referring to?
There was a problem hiding this comment.
Left over copy and paste from the build job.
| .\pythonbuild.exe validate-distribution --run $Dists | ||
|
|
||
| build-deps: | ||
| timeout-minutes: 90 |
Hm that's indeed annoying. I guess you could also generate the workflow file. |
2 participants
No description provided.