Skip to content

Conversation

@ThatXliner
Copy link
Member

@ThatXliner ThatXliner commented Jun 30, 2022

does also explicit activating the fixture work?

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

See atom-community/atom#399 (comment)

Alternate Designs

None so far.

Benefits

May fix tests

Possible Drawbacks

May break them.

Applicable Issues

Fixes #2

does also explicit activating the fixture work?
Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enabled GitHub Actions to see if the tests run.

@aminya aminya closed this Jul 3, 2022
@aminya aminya reopened this Jul 3, 2022
@aminya aminya closed this Jul 3, 2022
@aminya aminya reopened this Jul 3, 2022
Copy link
Member

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It doesn't break the tests

@aminya aminya changed the title Experiment: attempt to fix test Wait for activation of package-with-snippets Jul 3, 2022
@aminya aminya merged commit cdde119 into atom-community:master Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Snippets' failing tests

2 participants