Pull request for issue #46 #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two issues: 1. The `tour-the-gallery.sh` script was regenerating casts for all screensavers instead of using the existing ones. This has been refactored to use the casts from the `gallery/` directory, making the script much more efficient. 2. The `pipes.sh` screensaver was not being recorded correctly by `smile-for-the-camera.sh`. This was due to its use of the alternate screen buffer and other terminal manipulations. To fix this, the `pipes.sh` script has been modified to remove these features, making it compatible with `asciinema`. A test-specific copy of `pipes.sh` was created to test this solution before applying it to the main script.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46