feat: Update gallery tour to generate missing previews #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the gallery tour generation scripts for efficiency. - `spotlight/smile-for-the-camera.sh` can now generate a preview for a single screensaver when a directory is passed as an argument. - `spotlight/tour-the-gallery.sh` now checks for missing or empty `.cast` and `.gif` files and generates them on-demand for each screensaver, rather than regenerating all of them every time.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the gallery tour scripts to be more efficient.
The
spotlight/smile-for-the-camera.shscript is modified to accept a single screensaver directory as an argument. This allows for generating a preview for a single screensaver instead of all of them.The
spotlight/tour-the-gallery.shscript is updated to use this new functionality. It now checks for the existence and non-emptiness of the.castand.giffiles for each screensaver before adding them to the tour. If either file is missing or empty, it callssmile-for-the-camera.shto generate them for that specific screensaver. This avoids regenerating all previews every time the tour is created.