Fix cursor in casts, tour script, and test suite setup #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to only catch SIGINT. This prevents cursor restoration from being triggered by the `timeout` command during recording. Update `tour-the-gallery.sh` to use existing cast files generated by `smile-for-the-camera.sh` instead of creating new title card casts. Correct the `load` paths in all `bats` test files to be relative to the project root, fixing the test dependency loading issue.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
Update `tour-the-gallery.sh` to use existing cast files. Correct `load` paths in `bats` test files. Update all `.cast` files with new recordings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses three issues:
timeout.tour-the-gallery.shscript was creating new casts for title cards. This was changed to only use existing casts..batsfiles have been corrected.PR created automatically by Jules for task 13500521981430321241