Expect Dispatcher replies for TCP to be tuples, not lists #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in issue 176, according to the documentation one of the ways a callback function may pass a reply back to a client is by returning a message encapsulated thusly: `tuple(<Address>, <ArgValue>)`. Whilst the code for the UDP servers does conform to this, the code to TCP servers was expecting `list(<Address>, <ArgValue>)` in all cases. This PR resolves that, updating the tests as well.
Owner
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue 176, according to the documentation one of the ways a callback function may pass a reply back to a client is by returning a message encapsulated thusly:
tuple(<Address>, <ArgValue>).Whilst the code for the UDP servers does conform to this, the code to TCP servers was expecting
list(<Address>, <ArgValue>)in all cases.This PR resolves that, updating the tests as well.
Fixes #176