Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR standardizes the project’s supported Python versions by dropping 3.8 and adding 3.14 throughout the codebase, updates the release metadata, and tweaks the test runner configuration. Flow diagram for updated test session Python versions in Noxflowchart TD
NoxSession[Nox test session]
NoxSession -->|Runs tests on| Python39[Python 3.9]
NoxSession -->|Runs tests on| Python310[Python 3.10]
NoxSession -->|Runs tests on| Python311[Python 3.11]
NoxSession -->|Runs tests on| Python312[Python 3.12]
NoxSession -->|Runs tests on| Python313[Python 3.13]
NoxSession -->|Runs tests on| Python314[Python 3.14]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @avendesora - I've reviewed your changes - here's some feedback:
- The installation guide in docs/source/installation.rst still lists the old Python support and should be updated to match the new >=3.9 requirement.
- Make sure the project version in pyproject.toml (under tool.flit.metadata) is bumped to match the new release (0.13.1).
- Consider running the coverage session on the minimum supported Python version (3.9) instead of only on 3.13 to catch compatibility issues early.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The installation guide in docs/source/installation.rst still lists the old Python support and should be updated to match the new >=3.9 requirement.
- Make sure the project version in pyproject.toml (under tool.flit.metadata) is bumped to match the new release (0.13.1).
- Consider running the coverage session on the minimum supported Python version (3.9) instead of only on 3.13 to catch compatibility issues early.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:
Summary by Sourcery
Update project to drop Python 3.8 support and add Python 3.14 support across metadata, CI, configuration, and documentation while bumping the release version to 0.13.1.
Enhancements:
Build:
CI:
Documentation:
Chores: