doc: add links to contract tests with example comments#120
Open
hanseltime wants to merge 2 commits intoaws-cloudformation:masterfrom
Open
doc: add links to contract tests with example comments#120hanseltime wants to merge 2 commits intoaws-cloudformation:masterfrom
hanseltime wants to merge 2 commits intoaws-cloudformation:masterfrom
Conversation
hanseltime
force-pushed
the
add-contract-links
branch
from
8864eb8 to
88fe1a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
This PR adds some helpful comments and changes to the base handler.ts template to help new users understand the contracts that each endpoint (specifically list and read) are under.
Comments with links to relevant AWS doc are added as well as some changes to the initial code so that it doesn't look like we really should make and return models from the request back.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.