Skip to content

chore(ci): update layer script to include event-handler#4956

Merged
dreamorosi merged 3 commits intomainfrom
event-handler-llayer
Jan 28, 2026
Merged

chore(ci): update layer script to include event-handler#4956
dreamorosi merged 3 commits intomainfrom
event-handler-llayer

Conversation

@svozza
Copy link
Contributor

@svozza svozza commented Jan 19, 2026

Summary

The event-handler package is not included in the script that builds our lambda layers so we need to add it.

Changes

  • Updates layers/src/layer-publisher-stack.ts script to include the event-handler package

Issue number: closes #4955

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@svozza svozza self-assigned this Jan 19, 2026
@boring-cyborg boring-cyborg bot added the layers Items related to the Lambda Layers pipeline label Jan 19, 2026
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 19, 2026
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

It's not a one-liner, or I'd have done it right away.

We also need to come up with some kind of test case to be added here to make sure it doesn't break the layer.

@svozza
Copy link
Contributor Author

svozza commented Jan 19, 2026

Ah I see. And it's a sort of chicken and egg situation cos you can't test it until the code is in the layer.

@dreamorosi
Copy link
Contributor

dreamorosi commented Jan 19, 2026

Ah I see. And it's a sort of chicken and egg situation cos you can't test it until the code is in the layer.

No, the test builds the layer with whatever is in the build script you modified before running - that's the point of that canary.

@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Jan 28, 2026
@pull-request-size pull-request-size bot added size/S PR between 10-29 LOC and removed size/XS PR between 0-9 LOC labels Jan 28, 2026
@sonarqubecloud
Copy link

@dreamorosi dreamorosi dismissed their stale review January 28, 2026 11:40

Committed to the branch

@dreamorosi dreamorosi requested a review from sdangol January 28, 2026 11:40
@dreamorosi dreamorosi self-assigned this Jan 28, 2026
@dreamorosi
Copy link
Contributor

@sdangol - I had to make a commit to fix the PR. The end to end tests are passing, so this is ready to review and merge.

@dreamorosi dreamorosi merged commit 4a580d4 into main Jan 28, 2026
92 checks passed
@dreamorosi dreamorosi deleted the event-handler-llayer branch January 28, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

layers Items related to the Lambda Layers pipeline size/S PR between 10-29 LOC tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: add Event Handler in Lambda layer

3 participants