test for CfnIacImplementation.read_project#8296
Open
Sanenelisiwe1975 wants to merge 2 commits intoaws:developfrom
Open
test for CfnIacImplementation.read_project#8296Sanenelisiwe1975 wants to merge 2 commits intoaws:developfrom
Sanenelisiwe1975 wants to merge 2 commits intoaws:developfrom
Conversation
github-actions
bot
added
pr/external
stage/needs-triage
roger-zhangg
reviewed
Oct 8, 2025
Member
roger-zhangg
left a comment
roger-zhangg
left a comment
There was a problem hiding this comment.
Thanks for contributing, the new test LGTM, could you explain why you made the change on the old test
| impl = CdkIacImplementation(Mock()) | ||
| impl = CfnIacImplementation(MagicMock()) | ||
| impl.get_iac_file_patterns() | ||
| impl.read_project(Mock()) |
Member
There was a problem hiding this comment.
I don't think we need to delete this
|
|
||
| def test_cdk_implementation(self): | ||
| impl = CdkIacImplementation(Mock()) | ||
| impl = CfnIacImplementation(MagicMock()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
The previous test only checked method calls for coverage, not actual behavior.
This change ensures the method works as expected with a real CloudFormation template.
How does it address the issue?
Creates a temporary minimal template file.
Verifies that read_project returns a SamCliProject containing the expected stack and resource
What side effects does this change have?
No side effects; only adds a new unit test.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.