Skip to content

Conversation

@richardwang1124
Copy link
Contributor

Fixes flaky login credentials test regarding expiration.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

  1. To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the CHANGELOG.md file (at corresponding gem). For the description entry, please make sure it lives in one line and starts with Feature or Issue in the correct format.

  2. For generated code changes, please checkout below instructions first:
    https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md

Thank you for your contribution!

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

Detected 1 possible performance regressions:

  • aws-sdk-s3.require_time - z-score regression: 6.95 -> 24.65. Z-score: 18.34

Copy link
Contributor

@jterapin jterapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changelog entry needed for this fix. Let me know what you think about my second comment.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md.

Copy link
Contributor

@jterapin jterapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for handling the jruby_flakey tag on the uploader spec.

@richardwang1124 richardwang1124 merged commit f3cf7b8 into version-3 Jan 5, 2026
28 checks passed
@richardwang1124 richardwang1124 deleted the fix/flaky-test branch January 5, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants