Skip to content

Correctly tests US-ASCII encoding in S3 200 errors #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jterapin merged 1 commit into from
Jan 6, 2026
Merged

Correctly tests US-ASCII encoding in S3 200 errors #3341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions gems/aws-sdk-s3/spec/plugins/http_200_errors_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module Plugins
.to raise_error(Seahorse::Client::NetworkingError, /Empty or incomplete response body/)
end

it 'gracefully handle non-UTF encoding' do
it 'gracefully checks body when given ASCII encoding' do
response = <<~XML
<?xml version="1.0" encoding="UTF-8"?>
<DeleteResult>
Expand All @@ -44,14 +44,16 @@ module Plugins
</DeleteResult>
XML

allow_any_instance_of(Seahorse::Client::Http::Response)
.to receive(:body_contents)
.and_return(response.dup.force_encoding('US-ASCII'))

# No headers to replicate omitted Content-Type header
stub_request(:post, 'https://test-bucket.s3.amazonaws.com/?delete')
.to_return(status: 200, body: response, headers: {})
stub_request(:post, 'https://test-bucket.s3.amazonaws.com/?delete').to_return(status: 200, headers: {})

expect { client.delete_objects(bucket: 'test-bucket', delete: { objects: [{ key: 'test' }] }) }
.not_to raise_error
end

end
end
end
Expand Down
Loading