Merged
Conversation
* chore: Upgrade dependencies * revert upgrade of AngleSharp as it leads to runtime issues * Only target net80 and above for ci/cd * Remove generators from the build
Release of new minor version v1.40
There was a problem hiding this comment.
Pull Request Overview
This PR is an automated rebase by the bUnit bot to align the commit history with main and update various project files. Key changes include:
- Bumping the project version in version.json and updating the changelog.
- Updating target frameworks and removing project references and packing steps for bunit.generators.
- Updating package versions and CI/CD workflows to support only net8.0 and net9.0.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.json | Updated project version from "1.40-preview" to "1.41-preview", which appears misaligned with the changelog. |
| tests/bunit.generators.tests/bunit.generators.tests.csproj | Changed target framework from a single net8.0 to multiple frameworks and removed a ProjectReference to bunit.generators. |
| bunit.sln | Removed project entries related to bunit.generators, reflecting its removal from the solution. |
| Directory.Packages.props | Upgraded various NuGet packages and adjusted System.Text.Json versions across TFMs. |
| CHANGELOG.md | Added a new changelog entry for version [1.40.0] which appears inconsistent with version.json. |
| .github/workflows/release.yml, docs-deploy.yml, ci.yml | Removed support for older .NET versions and updated packing/test steps to target net8.0 and net9.0. |
Comments suppressed due to low confidence (5)
tests/bunit.generators.tests/bunit.generators.tests.csproj:28
- Removal of the bunit.generators project reference may affect test coverage for generator logic. Confirm that this removal is intentional and that related tests have been updated accordingly.
<ProjectReference Include="..\..\src\bunit.generators\bunit.generators.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
bunit.sln:64
- The removal of bunit.generators.tests and bunit.generators from the solution should be reviewed to ensure all dependent configurations and references have been updated.
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "bunit.generators.tests", "tests\bunit.generators.tests\bunit.generators.tests.csproj", "{09046981-D9EC-4295-8502-721AC54E1F12}"
.github/workflows/release.yml:100
- The removal of the dotnet pack command for bunit.generators indicates that this project is no longer being published. Ensure this change is consistent with the overall solution updates.
dotnet pack src/bunit.generators/ -c Release --property:PackageOutputPath=${GITHUB_WORKSPACE}/packages -p:ContinuousIntegrationBuild=true -p:publicrelease=true
.github/workflows/ci.yml:77
- Removing the bunit.generators pack step from the CI workflow should be confirmed to match the intended project structure and packaging strategy.
dotnet pack src/bunit.generators/ -c release --output ${{ env.NUGET_DIRECTORY }} -p:ContinuousIntegrationBuild=true -p:publicrelease=true
Directory.Packages.props:99
- System.Text.Json is set to version 9.0.5 for net9.0 while other frameworks remain on 8.0.5. Verify that this discrepancy is intentional and supported by the project requirements.
<PackageVersion Include="System.Text.Json" Version="9.0.5"/>
| { | ||
| "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/main/src/NerdBank.GitVersioning/version.schema.json", | ||
| "version": "1.40-preview", | ||
| "version": "1.41-preview", |
There was a problem hiding this comment.
The version in version.json ("1.41-preview") does not match the changelog entry ([1.40.0]). Consider aligning these to avoid confusion.
Suggested change
| "version": "1.41-preview", | |
| "version": "1.40.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created automatically by the bUnit bot.
When completing this PR, it's important to use Rebase and merge to keep the commit history clean.