Preparation for Localization: Migration of Hardcoded Strings and Licenses to Resources#218
Open
nbb1967 wants to merge 22 commits intobailey27:masterfrom
Open
Preparation for Localization: Migration of Hardcoded Strings and Licenses to Resources#218nbb1967 wants to merge 22 commits intobailey27:masterfrom
nbb1967 wants to merge 22 commits intobailey27:masterfrom
Conversation
CreateProperties. Move hardcoded strings to Resources (w/o listbox (!)).
FsInfoDialog. Hardcoded strings move to rc.
MountPropertyPage. Hardcoded strings moved to resources.
CryptPropertySheet. Hardcoded strings moved to resources.
Refactoring. FolderDialog. locutils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR initiates preparing the project for localization. The main goal is to separate the text content from the logic, which is currently a blocker for any translation efforts.
Implementation Details
Safety
The project compiles successfully in both Debug and Release configurations.
No functional logic was changed; the PR focuses solely on data storage and retrieval.
Although many files were touched, 95% of the changes are simple string-to-constant replacements.
Example of a working localized cppcryptfs interface (album on Imgur)