Skip to content

feat: Add Symfony 8 compatibility#66

Merged
barbieswimcrew merged 4 commits intobarbieswimcrew:masterfrom
Pixelshaped:symfony_8_compat
Feb 14, 2026
Merged

feat: Add Symfony 8 compatibility#66
barbieswimcrew merged 4 commits intobarbieswimcrew:masterfrom
Pixelshaped:symfony_8_compat

Conversation

@Pixelshaped
Copy link
Contributor

@Pixelshaped Pixelshaped commented Feb 13, 2026

Fix #65

Tried to implement it while respecting the intention of the package maintainer @barbieswimcrew

"I’d prefer to move towards supporting named parameters while keeping backward compatibility for now — so a compat layer that still handles the array-based options would make sense."

@Pixelshaped
Copy link
Contributor Author

Pixelshaped commented Feb 13, 2026

I had to modify compatibility by constraining versions of symfony/validator in e642f8c to unbreak CI under Composer’s security blocking (PKSA-w2tw-kmfg-rt9s), but I’m not sure we should merge this as-is.

This might prevent some users that were previously eligible to the package to install it and could be considered a breaking change. Maybe the CI rules should be loosened instead.

But I'd rather discuss it than make the call.

@Pixelshaped Pixelshaped requested a review from stof February 13, 2026 23:23
@stof
Copy link

stof commented Feb 13, 2026

This might prevent some users that were previously eligible to the package to install it and could be considered a breaking change.

if Composer does not install the new version because it knows there is an incompatibility, there is no BC break

@Pixelshaped
Copy link
Contributor Author

if Composer does not install the new version because it knows there is an incompatibility, there is no BC break

Then I guess we're in the clear? Let me know if this needs anything else.

Copy link

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I'm not a maintainer of that package)

@barbieswimcrew barbieswimcrew merged commit c85be5c into barbieswimcrew:master Feb 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support named parameters for the constraint constructor

3 participants

Comments