chore(builder): consolidated builder setup on shared node #682
+312
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyalprout
changed the title
danyalprout
force-pushed
the
danyal/simplify-builder-setup-2
branch
from
1098922 to
715de19
Compare
danyalprout
force-pushed
the
danyal/simplify-builder-setup-3
branch
from
7fc1d9d to
1aa0257
Compare
danyalprout
force-pushed
the
danyal/simplify-builder-setup-2
branch
from
715de19 to
f59e2cf
Compare
Collaborator
🟡 Heimdall Review Status
|
danyalprout
force-pushed
the
danyal/simplify-builder-setup-3
branch
from
1aa0257 to
6d999cb
Compare
…, move extension - Fix bug: replace manual EngineNodeLauncher creation with .launch() in runner, test_utils, and devnet (delegates to reth's default launcher) - Undo rename: NodeHooks back to BaseBuilder - Undo rename: NodeRunner back to BaseNodeRunner - Move MeteringStoreExtension from bin/builder into base-builder-metering crate Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Stacked on top of #679 - not yet ready for review.