chore(flashblocks): Strong, Domain Error Typing #315
Merged
+357
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
refcell
commented
Jan 8, 2026
meyer9
approved these changes
Jan 8, 2026
Collaborator
|
Review Error for meyer9 @ 2026-01-08 20:06:28 UTC |
haardikk21
reviewed
Jan 8, 2026
meyer9
previously approved these changes
Jan 8, 2026
Convert SenderRecovery variant to store String instead of RecoveryError to enable deriving Clone, Eq, and PartialEq traits. Also removes the custom Result type alias in favor of explicit Result<T, StateProcessorError>, updates imports to use top-level crate re-exports, and refactors tests to use rstest for parameterized testing.
refcell
force-pushed
the
rf/strong-error-type
branch
from
aa95dca to
7f259e1
Compare
haardikk21
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #312
Introduces a new
StateProcessorErrortype that strongly types errors in the flashblocks crate.