Skip to content

Conversation

@danyalprout
Copy link
Collaborator

Description

Update the eth_subscribe RPC to be in the eth/ RPC directory instead of the base directory.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 8, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

refcell
refcell previously approved these changes Jan 8, 2026
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@danyalprout danyalprout marked this pull request as draft January 8, 2026 19:56
@danyalprout danyalprout marked this pull request as ready for review January 9, 2026 05:29
@danyalprout danyalprout requested a review from refcell January 9, 2026 05:29
@danyalprout danyalprout merged commit 43fe872 into main Jan 9, 2026
19 checks passed
@danyalprout danyalprout deleted the danyal/pubsub branch January 9, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants