Skip to content

Conversation

@wlawt
Copy link
Contributor

@wlawt wlawt commented Nov 3, 2025

If set, adds syncmode flag and l2.enginekind flag to ADDITIONAL_ARGS which is useful for faster syncing from genesis for pruning.

Tested the shell conditional with a dummy script

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 3, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

# Configure engine kind for pruning
if [ "${RETH_ENGINE_KIND+x}" = x ]; then
echo "Adding engine kind arguments: $RETH_ENGINE_KIND"
ADDITIONAL_ARGS="$ADDITIONAL_ARGS --l2.enginekind=$RETH_ENGINE_KIND"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engine kind is for op-node binary

# Configure sync mode for pruning
if [ "${RETH_SYNC_MODE+x}" = x ]; then
echo "Adding sync mode arguments: $RETH_SYNC_MODE"
ADDITIONAL_ARGS="$ADDITIONAL_ARGS --syncmode=$RETH_SYNC_MODE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This var is for op-node binary

@wlawt wlawt closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants