-
Notifications
You must be signed in to change notification settings - Fork 1
fix(docs): example using load checkpoints API #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| ), | ||
| load_checkpoint_config=definitions.LoadCheckpointConfig( | ||
| enabled=True, | ||
| checkpoints=[definitions.BasetenCheckpoint.from_named_checkpoint(job_id="4q9g403", checkpoint_name="checkpoint-14")], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be from_latest?
rcano-baseten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about using from_latest so that this is kind of for free
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once comment is addressed
rcano-baseten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added one comment on file structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for file structure, I think the best thing to do would be this
- Put this in recipes, and at the highest level, give an explanation like you have here.
- Symlink the original example
- add a config.py that says
config_with_resume.pyand point it to the./symlink_folder/run.shwhen running
LMK WYT - I like to think of Recipes as "journeys" and Examples as "this is technically possible"
Add an example of how to restore checkpoints
Waiting for job to run, will only merge after verification of this change E2E