Skip to content

Bug fix: prevent newly added (child) instances from being deleted soon after. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amartis wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bug fix: prevent newly added (child) instances from being deleted soon after. #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59323ab
Bug fix: prevent newly added (child) instances from being deleted soo…
amartis Feb 17, 2022
8bdc056
Upgrade version
amartis Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drf_writable_nested/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
__title__ = 'DRF writable nested'
__version__ = '0.6.3'
__version__ = '0.6.4'
__author__ = 'beda.software'
__license__ = 'BSD 2-Clause'
__copyright__ = 'Copyright 2014-2020 beda.software'
Expand Down
12 changes: 11 additions & 1 deletion drf_writable_nested/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,10 @@ def update_or_create_reverse_relations(self, instance, reverse_relations):
try:
serializer.is_valid(raise_exception=True)
related_instance = serializer.save(**save_kwargs)
if not hasattr(self, 'nodelete_pks'):
self.nodelete_pks = {}
self.nodelete_pks[field_name] = self.nodelete_pks.get(field_name, [])
self.nodelete_pks[field_name].append(related_instance.pk)
data['pk'] = related_instance.pk
new_related_instances.append(related_instance)
errors.append({})
Expand Down Expand Up @@ -329,7 +333,13 @@ def delete_reverse_relations_if_need(self, instance, reverse_relations):
related_field.name: instance,
}

current_ids = self._extract_related_pks(field, related_data)
if not hasattr(self, 'nodelete_pks'):
current_ids = self._extract_related_pks(field, related_data)
else:
current_ids = self.nodelete_pks.get(
field_name,
self._extract_related_pks(field, related_data)
)

try:
pks_to_delete = list(
Expand Down