Skip to content

Only if PROJECT_IS_TOP_LEVEL use project_options #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dietmarkuehl merged 1 commit into from
Apr 25, 2025
Merged

Only if PROJECT_IS_TOP_LEVEL use project_options #139

dietmarkuehl merged 1 commit into from
Apr 25, 2025

Conversation

@ClausKlein
Copy link
Collaborator

@ClausKlein ClausKlein commented Apr 25, 2025

@ClausKlein ClausKlein requested review from a team, DeveloperPaul123 and inbal2l April 25, 2025 18:18
@ClausKlein ClausKlein self-assigned this Apr 25, 2025
dietmarkuehl
dietmarkuehl approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@dietmarkuehl dietmarkuehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although I admit that I don't quite understand what it does exactly.

@dietmarkuehl dietmarkuehl merged commit a8d2b34 into bemanproject:main Apr 25, 2025
11 checks passed
@ClausKlein
Copy link
Collaborator Author

ClausKlein commented Apr 26, 2025 •
edited
Loading

Looks good although I admit that I don't quite understand what it does exactly.

It prevent to link project_options and project_warnings if the project is imported from FetchContent via add_subdirectory() : see

execution/src/beman/execution/CMakeLists.txt

Line 9 in a8d2b34

if(NOT BEMAN_EXECUTION_ENABLE_INSTALL OR CMAKE_SKIP_INSTALL_RULES)

@ClausKlein ClausKlein deleted the feature/prevent-use-of-project-options branch December 7, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dietmarkuehl dietmarkuehl dietmarkuehl approved these changes

@camio camio Awaiting requested review from camio camio is a code owner

@DeveloperPaul123 DeveloperPaul123 Awaiting requested review from DeveloperPaul123

@inbal2l inbal2l Awaiting requested review from inbal2l

Assignees

@ClausKlein ClausKlein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ClausKlein @dietmarkuehl