Skip to content

fixed a problem with when_all missing set_stopped completions #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dietmarkuehl merged 1 commit into from
May 29, 2025
Merged

fixed a problem with when_all missing set_stopped completions #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion include/beman/execution/detail/when_all.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include <beman/execution/detail/transform_sender.hpp>
#include <beman/execution/detail/type_list.hpp>
#include <beman/execution/detail/value_types_of_t.hpp>
#include <beman/execution/detail/sends_stopped.hpp>

#include <concepts>
#include <exception>
Expand Down Expand Up @@ -250,7 +251,11 @@ struct completion_signatures_for_impl<
type;
using error_types = ::beman::execution::detail::meta::unique<
::beman::execution::detail::meta::combine<::beman::execution::error_types_of_t<Sender, Env, error_comps>...>>;
using type = ::beman::execution::detail::meta::combine<value_types, error_types>;
using stopped_types =
::std::conditional_t<(false || ... || ::beman::execution::sends_stopped<Sender, Env>),
::beman::execution::completion_signatures<::beman::execution::set_stopped_t()>,
::beman::execution::completion_signatures<>>;
using type = ::beman::execution::detail::meta::combine<value_types, error_types, stopped_types>;
};
} // namespace beman::execution::detail

Expand Down
3 changes: 3 additions & 0 deletions src/beman/execution/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ target_sources(
${PROJECT_SOURCE_DIR}/include/beman/execution/execution.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution/functional.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution/stop_token.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution26/execution.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution26/stop_token.hpp
PUBLIC FILE_SET
${TARGET_NAME}_detail_headers
TYPE
Expand All @@ -47,6 +49,7 @@ target_sources(
${PROJECT_SOURCE_DIR}/include/beman/execution/detail/basic_receiver.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution/detail/basic_sender.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution/detail/basic_state.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution/detail/bulk.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution/detail/call_result_t.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution/detail/callable.hpp
${PROJECT_SOURCE_DIR}/include/beman/execution/detail/check_type_alias_exist.hpp
Expand Down