Restore basic cmake features #154
Conversation
ClausKlein
requested review from
a team,
inbal2l and
steve-downey
and removed request for
a team
dietmarkuehl
left a comment
dietmarkuehl
left a comment
There was a problem hiding this comment.
The cmakeVersion changes should probably [also] go to exempler: this file is essentially a copy of the file there with a few references renamed.
I hadn't a local version of cmake-format: with that I'll also realise where cmake/Config.cmake.in is used and I'll restore it (again that is probably something which should [also] go to exemplar).
| set(CMAKE_C_COMPILER gcc) | ||
| set(CMAKE_CXX_COMPILER g++) |
There was a problem hiding this comment.
Apple ships with an executable named g++ which is really clang++. I'm not objecting to this change although I wonder what that implication! I could imagine that the name does imply different defaults, e.g., using libc++ for clang++ and libstdc++ for g++.
| struct state { | ||
| using operation_state_concept = ex::operation_state_t; | ||
| using child_state_t = decltype(ex::connect(std::declval<CSender>(), std::declval<own_receiver<Receiver>>())); | ||
| using child_state_t = decltype(ex::connect(std::declval<CSender>(), std::declval<own_receiver<Receiver> >())); |
There was a problem hiding this comment.
This change seems like an odd clang-format change. In the past >> was illegal but that changed a long time ago. I'd also think that happens in a lot of other places, just this file was recently changed.
| include (GNUInstallDirs) | ||
| include(GNUInstallDirs) | ||
|
|
||
| find_package(Threads REQUIRED) |
There was a problem hiding this comment.
Why is this dependency needed? As far as I can tell, things build and test on all major platforms without that. OK, looking things up seems to say that this helps deciding which threading library to use and it seems to ship with cmake - that should be fine.
dietmarkuehl
merged commit aaba2a9
into
bemanproject:update-for-beman-standards
2 participants
_denn_sie_wissen_nicht,_was_sie_tun