the final cleanup to my contribution

[ClausKlein]

I will not longer fight against windmills!

[coveralls]

coverage: 92.578% (+0.4%) from 92.179%
when pulling fe6ab19 on ClausKlein:feature/finish-my-contribution
into 73880e9 on bemanproject:main.

[ClausKlein]

@ednolan how is it possible the CI testcoverage changed without any code modification?

@dietmarkuehl random wait conditon affects the code coverage!

[ednolan]

I've disabled the setting that causes coverage decreases to cause CI failures. Coveralls will still leave comments on pull requests but will not fail the build. Unfortunately I think you need to resync the branch for this setting to apply.

[ClausKlein]

Unfortunately I think you need to resync the branch for this setting to apply.

Yes, no idea how?

[ednolan]

Just push an additional commit of any kind

[ClausKlein]

@ednolan now, it takes hours to build on ci?

[ednolan]

Not hours, but about a half an hour. It looks like the issue is that we're running into the concurrency limits of GitHub. If you check each individual job, they take less than 3 minutes to run, but because of the concurrency limits, many of them are running serially instead of in parallel.

[ClausKlein]

Not hours, but about a half an hour. It looks like the issue is that we're running into the concurrency limits of GitHub. If you check each individual job, they take less than 3 minutes to run, but because of the concurrency limits, many of them are running serially instead of in parallel.

3 pushes in 10 min. -> more than an hour to wait ...

Who pays for the time I am waiting for a review and than the rebase with push and again ....?