-
Notifications
You must be signed in to change notification settings - Fork 17
Don't set C++ standard version in the CMake #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
944b4bc to
e25d166
Compare
Doing so violates the [CMAKE.PASSIVE_PROJECT] requirement of the Beman Standard: https://github.com/bemanproject/beman/blob/main/docs/BEMAN_STANDARD.md#cmakepassive_projects Due to this setting, all the CI jobs were running with C++26 set, making the C++20 jobs spuriously pass. This commit removes them. It also changes the C++ standard version used by the presets from C++20 to C++23.
e25d166 to
2c8d96d
Compare
dietmarkuehl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you also disabled C++20. I thought the code would build with C++20. I may need to have a look at what breaks with C++20.
As an aside, I noticed the generic presets (debug and release) don't work with the setup from infra. That's a bit sad (I think I saw that Claus did have a PR for that but I haven't looked, yet).
|
This was the error I got when I tried building with Clang 20 and C++20: |
I would like to upstream the fix for this into exemplar. |
I have accepted Claus’s change. It did restore something you removed (there was a conflict about it which I resolved in favor of Claus’s version). |
OK, that makes sense: I guess I should disable this example (and possibly others) when building with a C++ version which doesn’t have the corresponding components. |
Doing so violates the [CMAKE.PASSIVE_PROJECT] requirement of the Beman Standard:
https://github.com/bemanproject/beman/blob/main/docs/BEMAN_STANDARD.md#cmakepassive_projects
Due to this setting, all the CI jobs were running with C++26 set, making the C++20 jobs spuriously pass. This commit removes them.