Skip to content

Conversation

@dietmarkuehl
Copy link
Member

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pre-commit

[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/alloc.cpp#L71-L71


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/alloc.cpp#L78-L78


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/alloc.cpp#L85-L85


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L17-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L34-L34


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L42-L42


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L46-L48


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L55-L60


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L62-L67


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L75-L77


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L81-L83


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L85-L86


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L89-L89


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L91-L91


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L99-L100


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/async-lock.cpp#L106-L108


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/co_await-result.cpp#L14-L15


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/co_await-result.cpp#L17-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/co_await-result.cpp#L19-L19


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/co_await-result.cpp#L22-L22


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/co_await-result.cpp#L24-L24


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/co_await-result.cpp#L26-L26


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/container.cpp#L16-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L15-L27


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L29-L44


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L46-L49


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L51-L56


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L58-L58


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L59-L62


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L64-L78


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L80-L80


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L81-L100


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L102-L103


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L105-L105


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L107-L107


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L109-L109


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/demo-thread_pool.hpp#L110-L110


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/error.cpp#L11-L13


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/error.cpp#L18-L18


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/error.cpp#L50-L51


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/error.cpp#L58-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/error.cpp#L63-L68


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/friendly.cpp#L14-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/hello.cpp#L12-L12


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/hello.cpp#L17-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/into_optional.cpp#L15-L15


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/into_optional.cpp#L31-L31


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/into_optional.cpp#L37-L44


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/into_optional.cpp#L49-L51


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/into_optional.cpp#L61-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/into_optional.cpp#L63-L63


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/into_optional.cpp#L67-L72


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/loop.cpp#L10-L11


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/loop.cpp#L16-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/loop.cpp#L19-L19


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/query.cpp#L14-L15


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/query.cpp#L21-L22


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/query.cpp#L29-L29


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/query.cpp#L32-L33


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/query.cpp#L37-L54


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/result_example.cpp#L13-L14


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/stop.cpp#L17-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/stop.cpp#L25-L26


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/stop.cpp#L31-L43


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/examples/stop.cpp#L45-L45


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/allocator.hpp#L14-L26


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/allocator.hpp#L28-L40


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/allocator.hpp#L42-L60


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/allocator.hpp#L62-L62


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L16-L24


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L26-L52


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L54-L59


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L61-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L63-L63


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L64-L82


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L84-L86


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L88-L88


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L89-L129


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L131-L132


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L134-L134


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L136-L140


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L143-L145


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L147-L154


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L157-L159


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L161-L166


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L168-L170


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L172-L172


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L173-L175


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L177-L180


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/any_scheduler.hpp#L182-L184


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/inline_scheduler.hpp#L14-L19


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/inline_scheduler.hpp#L21-L43


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/inline_scheduler.hpp#L45-L46


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L15-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L19-L21


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L25-L25


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L28-L28


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L30-L30


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L32-L32


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L34-L34


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L36-L36


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L38-L38


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L42-L42


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L47-L51


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L53-L53


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L55-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L67-L68


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L73-L75


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L80-L80


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/into_optional.hpp#L82-L82


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L19-L28


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L30-L34


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L36-L36


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L37-L42


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L44-L46


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L48-L59


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L61-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L63-L64


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L66-L67


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L70-L75


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L77-L104


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L106-L111


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L114-L123


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L125-L129


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L131-L138


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L140-L157


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L159-L163


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L165-L172


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L174-L175


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L177-L183


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L185-L186


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L188-L204


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L206-L220


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L222-L222


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L224-L258


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L260-L274


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L277-L290


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L292-L302


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L304-L304


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L305-L311


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/lazy.hpp#L314-L314


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/poly.hpp#L13-L21


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/poly.hpp#L23-L35


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/detail/stop_source.hpp#L12-L23


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/include/beman/lazy/lazy.hpp#L16-L54


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/tests/beman/lazy/CMakeLists.txt#L5-L8


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/22f0e5e66ee65d52e98d0b275204cf5e3181bcb6/tests/beman/lazy/lazy.test.cpp#L8-L9

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pre-commit

[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/demo-thread_pool.hpp#L80-L80


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/demo-thread_pool.hpp#L81-L100


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/demo-thread_pool.hpp#L102-L103


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/demo-thread_pool.hpp#L105-L105


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/demo-thread_pool.hpp#L107-L107


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/demo-thread_pool.hpp#L109-L109


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/demo-thread_pool.hpp#L110-L110


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/error.cpp#L11-L13


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/error.cpp#L18-L18


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/error.cpp#L50-L51


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/error.cpp#L58-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/error.cpp#L63-L68


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/friendly.cpp#L14-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/hello.cpp#L12-L12


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/hello.cpp#L17-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/into_optional.cpp#L15-L15


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/into_optional.cpp#L31-L31


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/into_optional.cpp#L37-L44


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/into_optional.cpp#L49-L51


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/into_optional.cpp#L61-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/into_optional.cpp#L63-L63


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/into_optional.cpp#L67-L72


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/loop.cpp#L10-L11


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/loop.cpp#L16-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/loop.cpp#L19-L19


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/query.cpp#L14-L15


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/query.cpp#L21-L22


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/query.cpp#L29-L29


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/query.cpp#L32-L33


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/query.cpp#L37-L54


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/result_example.cpp#L13-L14


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/stop.cpp#L17-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/stop.cpp#L25-L26


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/stop.cpp#L31-L43


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/examples/stop.cpp#L45-L45


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/allocator.hpp#L14-L26


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/allocator.hpp#L28-L40


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/allocator.hpp#L42-L60


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/allocator.hpp#L62-L62


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L16-L24


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L26-L52


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L54-L59


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L61-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L63-L63


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L64-L82


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L84-L86


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L88-L88


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L89-L129


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L131-L132


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L134-L134


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L136-L140


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L143-L145


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L147-L154


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L157-L159


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L161-L166


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L168-L170


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L172-L172


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L173-L175


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L177-L180


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/any_scheduler.hpp#L182-L184


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/inline_scheduler.hpp#L14-L19


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/inline_scheduler.hpp#L21-L43


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/inline_scheduler.hpp#L45-L46


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L15-L17


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L19-L21


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L25-L25


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L28-L28


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L30-L30


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L32-L32


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L34-L34


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L36-L36


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L38-L38


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L42-L42


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L47-L51


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L53-L53


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L55-L61


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L67-L68


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L73-L75


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L80-L80


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/into_optional.hpp#L82-L82


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L19-L28


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L30-L35


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L37-L42


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L44-L59


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L61-L62


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L64-L64


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L66-L68


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L70-L73


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L75-L89


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L91-L112


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L114-L123


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L125-L129


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L131-L138


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L140-L157


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L159-L163


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L165-L172


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L174-L175


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L177-L183


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L185-L186


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L188-L208


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L210-L220


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L224-L254


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L256-L258


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L260-L274


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L277-L290


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L292-L302


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L304-L304


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L305-L311


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/lazy.hpp#L314-L314


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/poly.hpp#L13-L21


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/poly.hpp#L23-L35


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/detail/stop_source.hpp#L12-L23


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/include/beman/lazy/lazy.hpp#L16-L54


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/tests/beman/lazy/CMakeLists.txt#L5-L8


[pre-commit] reported by reviewdog 🐶

https://github.com/bemanproject/lazy/blob/e6a460b97b971b974cd241b85573d054a2bb206d/tests/beman/lazy/lazy.test.cpp#L8-L9

return ::beman::lazy::detail::coroutine_allocate<C>(size, a...);
}
void operator delete(void* ptr, std::size_t size) {
#if defined(__GNUC__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
#if defined(__GNUC__)
#if defined(__GNUC__)

@wusatosi
Copy link
Member

Hum, LLVM 17 seem to fail because it try to link C++14 instead of c++20. What is happening here??

@dietmarkuehl
Copy link
Member Author

Hum, LLVM 17 seem to fail because it try to link C++14 instead of c++20. What is happening here??

That's actually not quite what's happening: clang++-17 uses libstdc++ from gcc-14*. That is where the 14 is coming from. There is some problem between clang++-17 and my [ab?]use of std::tuple when it is given libstdc++. It seems, clang++-18 doesn't have this problem and my current plan is to remove clang++-17 from the compilers to test with. I'm not sure if I'll be able to restore clang++-17 support (the issue seems to be with beman::execution for which I don't think I test with `clang++-17).

@wusatosi
Copy link
Member

Interesting... I disabled fail-fast, seems like this failure is specific to LLVM17.

@wusatosi
Copy link
Member

btw, thank you for using exemplar directly. This is very helpful for me to see how exemplar's CI system work in a real project.

@dietmarkuehl dietmarkuehl merged commit 28708d0 into main Jan 14, 2025
84 checks passed
@dietmarkuehl dietmarkuehl deleted the initial-implementation branch January 14, 2025 01:04
@dietmarkuehl
Copy link
Member Author

btw, thank you for using exemplar directly. This is very helpful for me to see how exemplar's CI system work in a real project.

It worked kind of OK. I took me something like an hour to get rid of all exemplar stuff and replace it with an initial implementation (which I had pretty much ready except for a few name changes). I didn't mess with the CI except that I needed to remove gcc-12 because it put up a fight and clang-17. Another oddity is that one of my examples replaces global operator new()/operator delete() which caused a problem with thread sanitizer on Mac. Also, some version of gcc seems to produce a [I think] spurious warning about using operator new()/operator delete() with different signatures but that is necessary in an allocator aware coroutine.

I know that my current implementation has at least one bug (one of the examples crashes when uncommenting stuff to proper state). It is also lacking tests and documentation: I plan to work on that to have a solid version, hopefully way ahead the Hagenberg meeting in 4 weeks.

Thanks!

@wusatosi
Copy link
Member

It worked kind of OK. I took me something like an hour to get rid of all exemplar stuff and replace it with an initial implementation (which I had pretty much ready except for a few name changes). I didn't mess with the CI except that I needed to remove gcc-12 because it put up a fight and clang-17.

Yeah I agree, we need to either parameterize exemplar or switch to using true templates. Was it intuitive where to add/ remove configs for the CI? Or is there anywhere that needs a bit more documentation?

@dietmarkuehl
Copy link
Member Author

When things didn't compile with older versions I struggled a bit locating where I need to modify things. Part of the problem was probably that git grep 12 (trying to located where gcc-12 came from) ignored the files in .github. Once I found it, it was easy enough to get rid of the config. Another problem I had was that I couldn't reproduce the issue. I have now set up a virtual machine (using Parallels) running Ubuntu to replicate at least the error (not quite the CI). Thinking of it - maybe I could have done that easier using Spaces. Maybe there are docs for that somewhere but I admit that I didn't go looking.

@wusatosi
Copy link
Member

When things didn't compile with older versions I struggled a bit locating where I need to modify things. Part of the problem was probably that git grep 12 (trying to located where gcc-12 came from) ignored the files in .github. Once I found it, it was easy enough to get rid of the config. Another problem I had was that I couldn't reproduce the issue. I have now set up a virtual machine (using Parallels) running Ubuntu to replicate at least the error (not quite the CI). Thinking of it - maybe I could have done that easier using Spaces. Maybe there are docs for that somewhere but I admit that I didn't go looking.

Ah I see. Thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants