-
Notifications
You must be signed in to change notification settings - Fork 8
added an init implementation for lazy #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pre-commit
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pre-commit
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
[pre-commit] reported by reviewdog 🐶
include/beman/lazy/detail/lazy.hpp
Outdated
| return ::beman::lazy::detail::coroutine_allocate<C>(size, a...); | ||
| } | ||
| void operator delete(void* ptr, std::size_t size) { | ||
| #if defined(__GNUC__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pre-commit] reported by reviewdog 🐶
| #if defined(__GNUC__) | |
| #if defined(__GNUC__) |
|
Hum, LLVM 17 seem to fail because it try to link C++14 instead of c++20. What is happening here?? |
That's actually not quite what's happening: |
|
Interesting... I disabled fail-fast, seems like this failure is specific to LLVM17. |
|
btw, thank you for using exemplar directly. This is very helpful for me to see how exemplar's CI system work in a real project. |
It worked kind of OK. I took me something like an hour to get rid of all I know that my current implementation has at least one bug (one of the examples crashes when uncommenting stuff to proper state). It is also lacking tests and documentation: I plan to work on that to have a solid version, hopefully way ahead the Hagenberg meeting in 4 weeks. Thanks! |
Yeah I agree, we need to either parameterize exemplar or switch to using true templates. Was it intuitive where to add/ remove configs for the CI? Or is there anywhere that needs a bit more documentation? |
|
When things didn't compile with older versions I struggled a bit locating where I need to modify things. Part of the problem was probably that |
Ah I see. Thank you for the feedback. |
No description provided.