Update beman-submodules and bring infra back in sync with upstream #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ednolan
requested review from
bretbrownjr,
dietmarkuehl,
neatudarius,
steve-downey and
wusatosi
as code owners
Pull request 43 (#43) removed compatibility with MSVC AddressSanitizer builds. The way this change should have been applied would have been to omit the "Release.MaxSan" build from the "msvc" build configuration and remove the "msvc-debug" preset from "ci_tests.yml" and CMakePresets.json, but instead the infra/cmake/msvc-toolchain.cmake file was modified to remove the sanitizer flag, making it out of sync with upstream infra. This should have been caught by the beman-submodule CI check, but was not due to a bug: bemanproject/infra-workflows@962bc39 This commit updates the ci_tests.yml file appropriately and updates both beman-submodules in this repository to the latest version. It also applies the exclusion rule to the CMake linter added by bemanproject/infra@0a25bfa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request 43 (#43) removed compatibility with MSVC AddressSanitizer builds. The way this change should have been applied would have been to omit the "Release.MaxSan" build from the "msvc" build configuration and remove the "msvc-debug" preset from "ci_tests.yml" and CMakePresets.json, but instead the infra/cmake/msvc-toolchain.cmake file was modified to remove the sanitizer flag, making it out of sync with upstream infra.
This should have been caught by the beman-submodule CI check, but was not due to a bug: bemanproject/infra-workflows@962bc39
This commit updates the ci_tests.yml file appropriately and updates both beman-submodules in this repository to the latest version.
It also applies the exclusion rule to the CMake linter added by bemanproject/infra@0a25bfa.