Skip to content

Allow PHP 8 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
estedev wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow PHP 8 #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b588bd0
allow PHP 8
djoos Apr 28, 2022
a4ae517
Symfony 5 tweak(s)
djoos Apr 29, 2022
362a972
allow use of Symfony 6 framework-bundle
djoos May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Collector/ProducerCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function __construct()
* @param Response $response A Response instance
* @param \Exception $exception An Exception instance
*/
public function collect(Request $request, Response $response, \Exception $exception = null)
public function collect(Request $request, Response $response, \Throwable $exception = null)
{
// We don't collect anything from the request data
}
Expand Down
4 changes: 2 additions & 2 deletions Command/DebugCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
namespace Bernard\BernardBundle\Command;

use Bernard\Router;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
* @final since 2.1
*/
class DebugCommand extends ContainerAwareCommand
class DebugCommand extends Command
{
/**
* @var Router
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@
},

"require" : {
"php": "^5.6|^7.0",
"php": "^5.6|^7.0|^8.0",
"bernard/bernard": "1.0.0-alpha9",
"symfony/framework-bundle": "^2.8|^3.2|^4.0|^5.0"
"symfony/framework-bundle": "^2.8|^3.2|^4.0|^5.0|^6.0"
},

"require-dev" : {
Expand Down