Add blockAndSend() and approveAndSend() methods to Response class#5
Open
tkaufmann wants to merge 1 commit intobeyondcode:mainfrom
Open
Add blockAndSend() and approveAndSend() methods to Response class#5tkaufmann wants to merge 1 commit intobeyondcode:mainfrom
tkaufmann wants to merge 1 commit intobeyondcode:mainfrom
Conversation
…e handling These methods combine decision-making with sending, eliminating the need for extended classes when replacing tool output. This is particularly useful for middleware hooks that intercept and replace tool functionality. - blockAndSend(): Block tool execution and immediately send response - approveAndSend(): Approve tool execution and immediately send response - Added tests for both new methods Use case: When building bridges (e.g., routing Claude's WebSearch to Perplexity), these methods allow clean interception without needing custom hook classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current Response class requires method chaining to build responses, but the
send()method is protected. This creates a gap when you need to immediately block or approve a tool and send the response in one operation.Currently, to block a tool and send the response, you must:
Solution
This PR adds two methods that combine decision-making with sending:
blockAndSend(string $reason): never- Blocks tool execution and sends responseapproveAndSend(string $reason = ''): never- Approves tool execution and sends responseUse Case
When building middleware hooks that intercept tool calls (e.g., routing WebSearch to a different API), you need to:
Without these methods, developers must create extended hook classes with custom logic.
Implementation
Testing
Added tests in
tests/Hooks/ExtendedResponseTest.phpto verify:Breaking Changes
None. These are new methods that don't affect existing functionality.
Alternative Considered
Making
send()public was considered but rejected to maintain encapsulation and prevent misuse of the response flow.